Correct the length calculation for the value field of GetPropertyReply.
authorEamon Walsh <ewalsh@tycho.nsa.gov>
Wed, 8 Apr 2009 03:56:33 +0000 (23:56 -0400)
committerEamon Walsh <ewalsh@tycho.nsa.gov>
Wed, 8 Apr 2009 03:56:33 +0000 (23:56 -0400)
value_len only contains the number of data units, which are 1, 2, or 4
bytes depending on the value of the format field.  The length of the
value field is thus value_len multiplied by the bytes per unit,
which is format / 8.

Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov>
src/xproto.xml

index 6313da6..920285a 100644 (file)
@@ -987,7 +987,13 @@ authorization from the authors.
       <field type="CARD32" name="value_len" />
       <pad bytes="12" />
       <list type="void" name="value">
-        <fieldref>value_len</fieldref>
+       <op op="*">
+         <fieldref>value_len</fieldref>
+         <op op="/">
+           <fieldref>format</fieldref>
+           <value>8</value>
+         </op>
+       </op>
       </list>
     </reply>
   </request>