queue2: warn if we can't remove our temporary file
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 7 Apr 2014 16:33:34 +0000 (17:33 +0100)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 7 Apr 2014 16:35:15 +0000 (17:35 +0100)
It's not fatal though, so do not error out.

Coverity 1037121

plugins/elements/gstqueue2.c

index 5389681..4feaf97 100644 (file)
@@ -1523,8 +1523,12 @@ gst_queue2_close_temp_location_file (GstQueue2 * queue)
   fflush (queue->temp_file);
   fclose (queue->temp_file);
 
-  if (queue->temp_remove)
-    remove (queue->temp_location);
+  if (queue->temp_remove) {
+    if (remove (queue->temp_location) < 0) {
+      GST_WARNING_OBJECT (queue, "Failed to remove temporary file %s: %s",
+          queue->temp_location, strerror (errno));
+    }
+  }
 
   queue->temp_file = NULL;
   clean_ranges (queue);