mmc: atmel-mci: Assign boolean values to a bool variable
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Wed, 20 Jan 2021 07:39:37 +0000 (15:39 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 1 Feb 2021 10:54:48 +0000 (11:54 +0100)
Fix the following coccicheck warnings:

./drivers/mmc/host/atmel-mci.c:2436:2-34: WARNING: Assignment
of 0/1 to bool variable.

./drivers/mmc/host/atmel-mci.c:2425:2-20: WARNING: Assignment
of 0/1 to bool variable.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Link: https://lore.kernel.org/r/1611128377-66216-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/atmel-mci.c

index 444bd3a..6324120 100644 (file)
@@ -2401,45 +2401,45 @@ static void atmci_get_cap(struct atmel_mci *host)
        dev_info(&host->pdev->dev,
                        "version: 0x%x\n", version);
 
-       host->caps.has_dma_conf_reg = 0;
-       host->caps.has_pdc = 1;
-       host->caps.has_cfg_reg = 0;
-       host->caps.has_cstor_reg = 0;
-       host->caps.has_highspeed = 0;
-       host->caps.has_rwproof = 0;
-       host->caps.has_odd_clk_div = 0;
-       host->caps.has_bad_data_ordering = 1;
-       host->caps.need_reset_after_xfer = 1;
-       host->caps.need_blksz_mul_4 = 1;
-       host->caps.need_notbusy_for_read_ops = 0;
+       host->caps.has_dma_conf_reg = false;
+       host->caps.has_pdc = true;
+       host->caps.has_cfg_reg = false;
+       host->caps.has_cstor_reg = false;
+       host->caps.has_highspeed = false;
+       host->caps.has_rwproof = false;
+       host->caps.has_odd_clk_div = false;
+       host->caps.has_bad_data_ordering = true;
+       host->caps.need_reset_after_xfer = true;
+       host->caps.need_blksz_mul_4 = true;
+       host->caps.need_notbusy_for_read_ops = false;
 
        /* keep only major version number */
        switch (version & 0xf00) {
        case 0x600:
        case 0x500:
-               host->caps.has_odd_clk_div = 1;
+               host->caps.has_odd_clk_div = true;
                fallthrough;
        case 0x400:
        case 0x300:
-               host->caps.has_dma_conf_reg = 1;
-               host->caps.has_pdc = 0;
-               host->caps.has_cfg_reg = 1;
-               host->caps.has_cstor_reg = 1;
-               host->caps.has_highspeed = 1;
+               host->caps.has_dma_conf_reg = true;
+               host->caps.has_pdc = false;
+               host->caps.has_cfg_reg = true;
+               host->caps.has_cstor_reg = true;
+               host->caps.has_highspeed = true;
                fallthrough;
        case 0x200:
-               host->caps.has_rwproof = 1;
-               host->caps.need_blksz_mul_4 = 0;
-               host->caps.need_notbusy_for_read_ops = 1;
+               host->caps.has_rwproof = true;
+               host->caps.need_blksz_mul_4 = false;
+               host->caps.need_notbusy_for_read_ops = true;
                fallthrough;
        case 0x100:
-               host->caps.has_bad_data_ordering = 0;
-               host->caps.need_reset_after_xfer = 0;
+               host->caps.has_bad_data_ordering = false;
+               host->caps.need_reset_after_xfer = false;
                fallthrough;
        case 0x0:
                break;
        default:
-               host->caps.has_pdc = 0;
+               host->caps.has_pdc = false;
                dev_warn(&host->pdev->dev,
                                "Unmanaged mci version, set minimum capabilities\n");
                break;