mfd: arizona: Fix rumtime PM imbalance on error
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 7 Apr 2021 05:11:49 +0000 (13:11 +0800)
committerLee Jones <lee.jones@linaro.org>
Wed, 14 Apr 2021 15:06:40 +0000 (16:06 +0100)
pm_runtime_get_sync() will increase the rumtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/arizona-irq.c

index 077d9ab..d919ae9 100644 (file)
@@ -100,7 +100,7 @@ static irqreturn_t arizona_irq_thread(int irq, void *data)
        unsigned int val;
        int ret;
 
-       ret = pm_runtime_get_sync(arizona->dev);
+       ret = pm_runtime_resume_and_get(arizona->dev);
        if (ret < 0) {
                dev_err(arizona->dev, "Failed to resume device: %d\n", ret);
                return IRQ_NONE;