atm: br2684: Do not move counters backwards
authorJorge Boncompte [DTI2] <jorge@dti2.net>
Mon, 21 Nov 2011 10:25:54 +0000 (10:25 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Nov 2011 21:15:22 +0000 (16:15 -0500)
This snippet has caused several bugs in the past, and I don't see the
point on substracting the skb len from netdev stats.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/atm/br2684.c

index d07223c..81cf33b 100644 (file)
@@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
        skb_queue_splice_init(rq, &queue);
        spin_unlock_irqrestore(&rq->lock, flags);
 
-       skb_queue_walk_safe(&queue, skb, tmp) {
-               struct net_device *dev;
-
+       skb_queue_walk_safe(&queue, skb, tmp)
                br2684_push(atmvcc, skb);
-               dev = skb->dev;
-
-               dev->stats.rx_bytes -= skb->len;
-               dev->stats.rx_packets--;
-       }
 
        /* initialize netdev carrier state */
        if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)