panfrost: Only emit images when they are present
authorIcecream95 <ixn@disroot.org>
Sun, 10 Jul 2022 08:48:16 +0000 (20:48 +1200)
committerMarge Bot <emma+marge@anholt.net>
Sat, 23 Jul 2022 00:56:10 +0000 (00:56 +0000)
nr_images is the trigger for allocating double the number of buffers
for attributes. When there are no images, there is not always enough
space for ALIGN_POT(k, 2) to not move k out of bounds, so don't
execute the line in that case.

Fixes: dc85f65e059 ("panfrost: emit shader image attribute descriptors")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17447>

src/gallium/drivers/panfrost/pan_cmdstream.c

index 7e4ec15..4dd8fcb 100644 (file)
@@ -2165,10 +2165,12 @@ panfrost_emit_vertex_data(struct panfrost_batch *batch,
         }
 #endif
 
-        k = ALIGN_POT(k, 2);
-        emit_image_attribs(ctx, PIPE_SHADER_VERTEX, out + so->num_elements, k);
-        emit_image_bufs(batch, PIPE_SHADER_VERTEX, bufs + k, k);
-        k += (util_last_bit(ctx->image_mask[PIPE_SHADER_VERTEX]) * 2);
+        if (nr_images) {
+                k = ALIGN_POT(k, 2);
+                emit_image_attribs(ctx, PIPE_SHADER_VERTEX, out + so->num_elements, k);
+                emit_image_bufs(batch, PIPE_SHADER_VERTEX, bufs + k, k);
+                k += (util_last_bit(ctx->image_mask[PIPE_SHADER_VERTEX]) * 2);
+        }
 
 #if PAN_ARCH >= 6
         /* We need an empty attrib buf to stop the prefetching on Bifrost */