part: Fix bogus return from part_get_info_by_dev_and_name
authorSean Anderson <sean.anderson@seco.com>
Mon, 12 Apr 2021 22:53:06 +0000 (18:53 -0400)
committerTom Rini <trini@konsulko.com>
Thu, 22 Apr 2021 18:09:45 +0000 (14:09 -0400)
blk_get_device_by_str returns the device number on success. So we must
check if the return was negative to determine an error.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
disk/part.c

index 80ced2b..5e7e59c 100644 (file)
@@ -725,7 +725,7 @@ static int part_get_info_by_dev_and_name(const char *dev_iface,
        }
 
        ret = blk_get_device_by_str(dev_iface, dev_str, dev_desc);
-       if (ret)
+       if (ret < 0)
                goto cleanup;
 
        ret = part_get_info_by_name(*dev_desc, part_str, part_info);