perf cs-etm: Remove unused stub methods
authorJames Clark <james.clark@arm.com>
Mon, 12 Dec 2022 15:55:10 +0000 (15:55 +0000)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 14 Dec 2022 14:24:31 +0000 (11:24 -0300)
These aren't used outside of cs-etm so don't need stubs. Leave
cs_etm__process_auxtrace_info() which is used externally, and add an
error message so that it's obvious to users why it causes errors.

Signed-off-by: James Clark <james.clark@arm.com>
Cc: Al Grant <Al.Grant@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Mike Leach <mike.leach@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: coresight@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20221212155513.2259623-3-james.clark@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/cs-etm.h

index 90c83f9..401f74b 100644 (file)
@@ -7,6 +7,7 @@
 #ifndef INCLUDE__UTIL_PERF_CS_ETM_H__
 #define INCLUDE__UTIL_PERF_CS_ETM_H__
 
+#include "debug.h"
 #include "util/event.h"
 #include <linux/bits.h>
 
@@ -218,40 +219,9 @@ static inline int
 cs_etm__process_auxtrace_info(union perf_event *event __maybe_unused,
                              struct perf_session *session __maybe_unused)
 {
+       pr_err("\nCS ETM Trace: OpenCSD is not linked in, please recompile with CORESIGHT=1\n");
        return -1;
 }
-
-static inline int cs_etm__get_cpu(u8 trace_chan_id __maybe_unused,
-                                 int *cpu __maybe_unused)
-{
-       return -1;
-}
-
-static inline int cs_etm__etmq_set_tid(
-                               struct cs_etm_queue *etmq __maybe_unused,
-                               pid_t tid __maybe_unused,
-                               u8 trace_chan_id __maybe_unused)
-{
-       return -1;
-}
-
-static inline bool cs_etm__etmq_is_timeless(
-                               struct cs_etm_queue *etmq __maybe_unused)
-{
-       /* What else to return? */
-       return true;
-}
-
-static inline void cs_etm__etmq_set_traceid_queue_timestamp(
-                               struct cs_etm_queue *etmq __maybe_unused,
-                               u8 trace_chan_id __maybe_unused) {}
-
-static inline struct cs_etm_packet_queue *cs_etm__etmq_get_packet_queue(
-                               struct cs_etm_queue *etmq __maybe_unused,
-                               u8 trace_chan_id __maybe_unused)
-{
-       return NULL;
-}
 #endif
 
 #endif