phy: cadence: salvo: add bist fix
authorPeter Chen <peter.chen@nxp.com>
Wed, 17 May 2023 16:16:43 +0000 (12:16 -0400)
committerVinod Koul <vkoul@kernel.org>
Fri, 19 May 2023 17:44:06 +0000 (23:14 +0530)
Very limited parts may fail to work on full speed mode (both host and
device modes) for USB3 port due to higher threshold in full speed receiver
of USB2.0 PHY.

One example failure symptom is, the enumeration is failed when connecting
full speed USB mouse to USB3 port, especially under high temperature.

The workaround is to configure threshold voltage value of single ended
receiver by setting USB2.0 PHY register AFE_RX_REG5[2:0] to 3'b101.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20230517161646.3418250-4-Frank.Li@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/cadence/phy-cadence-salvo.c

index 2e3d4d8..5633fd2 100644 (file)
@@ -91,6 +91,7 @@
 
 /* USB2 PHY register definition */
 #define UTMI_REG15                             0xaf
+#define UTMI_AFE_RX_REG5                       0x12
 
 /* TB_ADDR_TX_RCVDETSC_CTRL */
 #define RXDET_IN_P3_32KHZ                      BIT(0)
@@ -247,6 +248,7 @@ static int cdns_salvo_phy_init(struct phy *phy)
        cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_REG15,
                         value | TXVALID_GATE_THRESHOLD_HS_0US);
 
+       cdns_salvo_write(salvo_phy, USB2_PHY_OFFSET, UTMI_AFE_RX_REG5, 0x5);
        udelay(10);
 
        clk_disable_unprepare(salvo_phy->clk);