Update BackButton handling
authorSeungkeun Lee <sngn.lee@samsung.com>
Mon, 15 May 2017 06:47:25 +0000 (15:47 +0900)
committerKangho Hur <kangho.hur@samsung.com>
Mon, 10 Jul 2017 02:11:25 +0000 (11:11 +0900)
 - requried commit : https://review.tizen.org/gerrit/#/c/128937/
 - KeyGrab with exclusive mode has issue
 - BackButtonPressed event was introduced in ElmSharp

Change-Id: I9780ff0216e9dfb3ebc5b9e9bf11390fa60bfbec

Xamarin.Forms.Platform.Tizen/Native/Dialog.cs
Xamarin.Forms.Platform.Tizen/Native/Window.cs
Xamarin.Forms.Platform.Tizen/Xamarin.Forms.Platform.Tizen.csproj

index c59755f..6d1dde1 100644 (file)
@@ -25,11 +25,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                }
 
                /// <summary>
-               /// Occurs when the hardware Back button is pressed.
-               /// </summary>
-               public event EventHandler BackButtonPressed;
-
-               /// <summary>
                /// Occurs whenever the dialog is first displayed.
                /// </summary>
                public event EventHandler Shown;
@@ -155,8 +150,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                        ApplyButton(ButtonPosition.Negative, null);
                        ApplyContent(null);
 
-                       UngrabBackKey();
-
                        base.OnUnrealize();
                }
 
@@ -166,7 +159,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                /// <remarks>When shown, the dialog will register itself for the back key press event handling.</remarks>
                protected virtual void OnShown()
                {
-                       GrabBackKey();
                }
 
                /// <summary>
@@ -175,7 +167,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                /// <remarks>When dismissed, the dialog will unregister itself from the back key press event handling.</remarks>
                protected virtual void OnDismissed()
                {
-                       UngrabBackKey();
                }
 
                /// <summary>
@@ -199,15 +190,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                        {
                                OnShown();
                        };
-
-                       // Adds a handler for the KeyUp event.
-                       // The handler checks whether the key just pressed is a back key
-                       // and if that is the case, invokes the back button press handler of this instance.
-                       KeyUp += (s, e) =>
-                       {
-                               if (e.KeyName == EvasKeyEventArgs.PlatformBackButtonName)
-                                       BackButtonPressed?.Invoke(this, EventArgs.Empty);
-                       };
                }
 
                /// <summary>
@@ -262,22 +244,5 @@ namespace Xamarin.Forms.Platform.Tizen.Native
 
                        SetPartContent("default", _content, true);
                }
-
-               /// <summary>
-               /// Registers this instance to be affected by pressing the hardware back key.
-               /// </summary>
-               void GrabBackKey()
-               {
-                       KeyGrab(EvasKeyEventArgs.PlatformBackButtonName, true);
-               }
-
-               /// <summary>
-               /// Unregisters this instance from being affected by pressing the hardware back key.
-               /// </summary>
-               void UngrabBackKey()
-               {
-                       KeyUngrab(EvasKeyEventArgs.PlatformBackButtonName);
-               }
-
        }
 }
index 2bc45c6..3e982ae 100644 (file)
@@ -24,11 +24,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                public event EventHandler Closed;
 
                /// <summary>
-               /// Notifies that the back button has been pressed.
-               /// </summary>
-               public event EventHandler BackButtonPressed;
-
-               /// <summary>
                /// Gets the current orientation.
                /// </summary>
                public DisplayOrientations CurrentOrientation
@@ -105,15 +100,6 @@ namespace Xamarin.Forms.Platform.Tizen.Native
                                Unrealize();
                        };
 
-                       KeyGrab(EvasKeyEventArgs.PlatformBackButtonName, false);
-                       KeyUp += (s, e) =>
-                       {
-                               if (e.KeyName == EvasKeyEventArgs.PlatformBackButtonName)
-                               {
-                                       BackButtonPressed?.Invoke(this, EventArgs.Empty);
-                               }
-                       };
-
                        Active();
                        AutoDeletion = false;
                        Show();
index 22ff9d7..1c39626 100644 (file)
@@ -9,7 +9,7 @@
     <PackageReference Include="Tizen" Version="1.0.5" />
     <PackageReference Include="Tizen.Applications.Common" Version="1.5.5" />
     <PackageReference Include="Tizen.Applications.UI" Version="1.5.5" />
-    <PackageReference Include="ElmSharp" Version="1.1.0-beta-022" />
+    <PackageReference Include="ElmSharp" Version="1.1.0-beta-024" />
     <PackageReference Include="System.Runtime.Serialization.Xml" Version="4.3.0" />
     <PackageReference Include="Tizen.System.Information" Version="1.0.2" />
     <PackageReference Include="Tizen.WebView" Version="1.0.0" />