static_call: Replace pointless WARN_ON() in static_call_module_notify()

static_call_module_notify() triggers a WARN_ON(), when memory allocation
fails in __static_call_add_module().

That's not really justified, because the failure case must be correctly
handled by the well known call chain and the error code is passed
through to the initiating userspace application.

A memory allocation fail is not a fatal problem, but the WARN_ON() takes
the machine out when panic_on_warn is set.

Replace it with a pr_warn().

Fixes: 9183c3f9ed71 ("static_call: Add inline static call infrastructure")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/8734mf7pmb.ffs@tglx

diff --git a/kernel/static_call_inline.c b/kernel/static_call_inline.c
index 7bb0962b5229181af895b3398d528eacd5ff3a7d..5259cda486d058f4bb2f75c2cef3be2f6d8f3b57 100644 (file)
--- a/kernel/static_call_inline.c
+++ b/kernel/static_call_inline.c
@@ -453,7 +453,7 @@ static int static_call_module_notify(struct notifier_block *nb,
        case MODULE_STATE_COMING:
                ret = static_call_add_module(mod);
                if (ret) {
-                       WARN(1, "Failed to allocate memory for static calls");
+                       pr_warn("Failed to allocate memory for static calls\n");
                        static_call_del_module(mod);
                }
                break;