login: add a missing error check for session_set_leader()
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 14 Feb 2019 01:59:13 +0000 (10:59 +0900)
committerLennart Poettering <lennart@poettering.net>
Fri, 15 Feb 2019 10:29:34 +0000 (11:29 +0100)
session_set_leader() may fail. If it fails, then manager_start_scope()
will trigger assertion.

This may be related to RHBZ#1663704.

src/login/logind-dbus.c

index 8ab498f..b9ea370 100644 (file)
@@ -790,7 +790,9 @@ static int method_create_session(sd_bus_message *message, void *userdata, sd_bus
                 goto fail;
 
         session_set_user(session, user);
-        session_set_leader(session, leader);
+        r = session_set_leader(session, leader);
+        if (r < 0)
+                goto fail;
 
         session->type = t;
         session->class = c;