Fix memory leak 69/56269/2
authorWootak Jung <wootak.jung@samsung.com>
Wed, 6 Jan 2016 02:30:58 +0000 (11:30 +0900)
committerWootak Jung <wootak.jung@samsung.com>
Wed, 6 Jan 2016 04:49:35 +0000 (20:49 -0800)
Change-Id: I67406174e5f80939e16b5902f78d085b9c1a719b

packaging/capi-telephony.spec
src/telephony_modem.c
src/telephony_network.c
src/telephony_sim.c

index 0918975e1577218d49abb7c3413f59e90ab49b9d..dfcc156696e5025335d9e32ed8d9cc7030e10eaf 100644 (file)
@@ -1,6 +1,6 @@
 Name:       capi-telephony
 Summary:    Telephony Core API
-Version:    0.1.51
+Version:    0.1.52
 Release:    1
 Group:      System/Libraries
 License:    Apache-2.0
index d90f52732923abe9820fdbc64435a1a7514ad23e..b2c0e5b5a965ba9b0c13c77ee78757375e156d6e 100644 (file)
@@ -55,12 +55,14 @@ int telephony_modem_get_imei(telephony_h handle, char **imei)
                        }
                        g_free(tapi_imei);
                }
+               g_variant_unref(gv);
        } else {
                LOGE("g_dbus_conn failed. error (%s)", gerr->message);
                if (strstr(gerr->message, "AccessDenied")) {
                        LOGE("PERMISSION_DENIED");
                        error = TELEPHONY_ERROR_PERMISSION_DENIED;
                }
+               g_error_free(gerr);
        }
 
        return error;
index d7db2f6c8b90f2b13438c4c64bfa70a4f368a2a5..402342c9065c7e89b44d9edd7fda84e9e0eeb601 100644 (file)
@@ -27,9 +27,6 @@
 #include "telephony_common.h"
 #include "telephony_private.h"
 
-#include <sys/types.h>
-#include <unistd.h>
-
 static int __get_serving_network(TapiHandle *tapi_h, TelNetworkServing_t *data)
 {
        int ret;
index fb69829a2db7b63e9389d86f79510736783f5400..22a9afbab221b46d75e44ad44f5e3b1d887c1c38 100644 (file)
@@ -124,6 +124,7 @@ int telephony_sim_get_icc_id(telephony_h handle, char **icc_id)
                                error_code = TELEPHONY_ERROR_OPERATION_FAILED;
                        }
                        g_free(iccid);
+                       g_variant_unref(sync_gv);
                } else {
                        LOGE("g_dbus_conn failed. error (%s)", gerr->message);
                        error_code = _convert_dbus_errmsg_to_sim_error(gerr->message);
@@ -246,6 +247,7 @@ int telephony_sim_get_spn(telephony_h handle, char **spn)
                                error_code = TELEPHONY_ERROR_OPERATION_FAILED;
                        }
                        g_free(spn_str);
+                       g_variant_unref(sync_gv);
                } else {
                        LOGE("g_dbus_conn failed. error (%s)", gerr->message);
                        error_code = _convert_dbus_errmsg_to_sim_error(gerr->message);
@@ -403,6 +405,7 @@ int telephony_sim_get_subscriber_number(telephony_h handle, char **subscriber_nu
                } else {
                        error_code = TELEPHONY_ERROR_OPERATION_FAILED;
                }
+               g_variant_unref(sync_gv);
        } else {
                LOGE("g_dbus_conn failed. error (%s)", gerr->message);
                error_code = _convert_dbus_errmsg_to_sim_error(gerr->message);
@@ -557,6 +560,7 @@ int telephony_sim_get_gid1(telephony_h handle, char **gid1)
                        } else {
                                error_code = TELEPHONY_ERROR_OPERATION_FAILED;
                        }
+                       g_variant_unref(sync_gv);
                } else {
                        LOGE("g_dbus_conn failed. error (%s)", gerr->message);
                        error_code = _convert_dbus_errmsg_to_sim_error(gerr->message);