Fix SVACE Warnings 39/105539/1
authorkiso.chang <kiso.chang@samsung.com>
Mon, 19 Dec 2016 03:22:17 +0000 (12:22 +0900)
committerkiso.chang <kiso.chang@samsung.com>
Mon, 19 Dec 2016 03:22:40 +0000 (12:22 +0900)
Change-Id: I628a9f61b5366576bcc400809efb641192b84137
Signed-off-by: kiso.chang <kiso.chang@samsung.com>
setting-about/src/setting-about-status.c
setting-network/src/setting-network.c [changed mode: 0644->0755]

index 87afa96f91c093dc7a9b04bec7b8807eab62dcc4..d214efd2c3c4d19c39b2c0620caf172290583ccd 100755 (executable)
@@ -431,8 +431,8 @@ static void __get_storage_capacity(char *str, int size)
                snprintf(str, size, "%s", _("IDS_ST_HEADER_UNAVAILABLE"));
                return;
        } else {
-               total = internal.f_frsize * internal.f_blocks;
-               avail = internal.f_bsize * internal.f_bavail;
+               total = (long long int )internal.f_frsize * (long long int )internal.f_blocks;
+               avail = (long long int )internal.f_bsize * (long long int )internal.f_bavail;
                SETTING_TRACE_DEBUG("Total mem : %lld, Avail mem : %lld",
                                        total, avail);
        }
@@ -440,8 +440,8 @@ static void __get_storage_capacity(char *str, int size)
        if (storage_get_external_memory_size(&external) < 0) {
                SETTING_TRACE_DEBUG("Fail to get external memory size");
        } else {
-               total += external.f_frsize * external.f_blocks;
-               avail += external.f_bsize * external.f_bavail;
+               total += (long long int )external.f_frsize * (long long int )external.f_blocks;
+               avail += (long long int )external.f_bsize * (long long int )external.f_bavail;
                SETTING_TRACE_DEBUG("Total mem : %lld, Avail mem : %lld",
                                                        total, avail);
        }
old mode 100644 (file)
new mode 100755 (executable)
index 6e01165..33302f2
@@ -1965,11 +1965,15 @@ bool setting_network_equal_profile(connection_profile_h pf1,
                SETTING_TRACE("They have same key fields, return TRUE.");
                FREE(apn1);
                FREE(apn2);
+               FREE(name1);
+               FREE(name2);
                return TRUE;
        } else {
                SETTING_TRACE("They don't have same key fields, return FALSE.");
                FREE(apn1);
                FREE(apn2);
+               FREE(name1);
+               FREE(name2);
                return FALSE;
        }
 }
@@ -1991,11 +1995,6 @@ static int __profile_item_sort_cb(const void *d1, const void *d2)
        connection_profile_get_id(pf1, &id_str1);
        connection_profile_get_id(pf2, &id_str2);
 
-       char *name1 = NULL;
-       char *name2 = NULL;
-       connection_profile_get_name(pf1, &name1);
-       connection_profile_get_name(pf2, &name2);
-
        if (isEmptyStr(id_str1)) {
                FREE(id_str1);
                FREE(id_str2);
@@ -2014,8 +2013,17 @@ static int __profile_item_sort_cb(const void *d1, const void *d2)
        safeCopyStr(str2, id_str2, MAX_ID_LEN);
        G_FREE(id_str1);
        G_FREE(id_str2);
-       /*SETTING_TRACE("str1:%s, name1:%s", str1, name1); */
-       /*SETTING_TRACE("str2:%s, name2:%s", str2, name2); */
+
+/*
+       char *name1 = NULL;
+       char *name2 = NULL;
+       connection_profile_get_name(pf1, &name1);
+       connection_profile_get_name(pf2, &name2);
+       SETTING_TRACE("str1:%s, name1:%s", str1, name1); 
+       SETTING_TRACE("str2:%s, name2:%s", str2, name2); 
+       FREE(name1);
+       FREE(name2);
+*/
 
        char *p = NULL;
        /*for id1.. */