ASoC: codecs: es8326: Fix DTS properties reading
authorAlexey Firago <a.firago@yadro.com>
Sat, 4 Feb 2023 19:51:06 +0000 (22:51 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 6 Feb 2023 13:12:34 +0000 (13:12 +0000)
Seems like properties parsing and reading was copy-pasted,
so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
the es8326->jack_pol variable. This might lead to wrong settings
being saved into the reg 57 (ES8326_HP_DET).

Fix this by using proper variables while reading properties.

Signed-off-by: Alexey Firago <a.firago@yadro.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com
Link: https://lore.kernel.org/r/20230204195106.46539-1-a.firago@yadro.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/es8326.c

index 9ddf6a3..28a0565 100755 (executable)
@@ -729,14 +729,16 @@ static int es8326_probe(struct snd_soc_component *component)
        }
        dev_dbg(component->dev, "jack-pol %x", es8326->jack_pol);
 
-       ret = device_property_read_u8(component->dev, "everest,interrupt-src", &es8326->jack_pol);
+       ret = device_property_read_u8(component->dev, "everest,interrupt-src",
+                                     &es8326->interrupt_src);
        if (ret != 0) {
                dev_dbg(component->dev, "interrupt-src return %d", ret);
                es8326->interrupt_src = ES8326_HP_DET_SRC_PIN9;
        }
        dev_dbg(component->dev, "interrupt-src %x", es8326->interrupt_src);
 
-       ret = device_property_read_u8(component->dev, "everest,interrupt-clk", &es8326->jack_pol);
+       ret = device_property_read_u8(component->dev, "everest,interrupt-clk",
+                                     &es8326->interrupt_clk);
        if (ret != 0) {
                dev_dbg(component->dev, "interrupt-clk return %d", ret);
                es8326->interrupt_clk = 0x45;