btrfs: open code set_extent_dirty
authorDavid Sterba <dsterba@suse.com>
Wed, 24 May 2023 23:04:28 +0000 (01:04 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 19 Jun 2023 11:59:30 +0000 (13:59 +0200)
The helper is used a few times, that it's setting the DIRTY extent bit
is still clear.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/block-group.c
fs/btrfs/extent-io-tree.h
fs/btrfs/extent-tree.c

index 590b035..ec463f8 100644 (file)
@@ -3521,9 +3521,10 @@ int btrfs_update_block_group(struct btrfs_trans_handle *trans,
                        spin_unlock(&cache->lock);
                        spin_unlock(&space_info->lock);
 
-                       set_extent_dirty(&trans->transaction->pinned_extents,
-                                        bytenr, bytenr + num_bytes - 1,
-                                        GFP_NOFS | __GFP_NOFAIL);
+                       set_extent_bit(&trans->transaction->pinned_extents,
+                                      bytenr, bytenr + num_bytes - 1,
+                                      EXTENT_DIRTY, NULL,
+                                      GFP_NOFS | __GFP_NOFAIL);
                }
 
                spin_lock(&trans->transaction->dirty_bgs_lock);
index 293e493..0fc5454 100644 (file)
@@ -175,12 +175,6 @@ static inline int clear_extent_uptodate(struct extent_io_tree *tree, u64 start,
                                  cached_state, GFP_NOFS, NULL);
 }
 
-static inline int set_extent_dirty(struct extent_io_tree *tree, u64 start,
-               u64 end, gfp_t mask)
-{
-       return set_extent_bit(tree, start, end, EXTENT_DIRTY, NULL, mask);
-}
-
 static inline int clear_extent_dirty(struct extent_io_tree *tree, u64 start,
                                     u64 end, struct extent_state **cached)
 {
index 5c7c720..47cfb69 100644 (file)
@@ -2507,8 +2507,9 @@ static int pin_down_extent(struct btrfs_trans_handle *trans,
        spin_unlock(&cache->lock);
        spin_unlock(&cache->space_info->lock);
 
-       set_extent_dirty(&trans->transaction->pinned_extents, bytenr,
-                        bytenr + num_bytes - 1, GFP_NOFS | __GFP_NOFAIL);
+       set_extent_bit(&trans->transaction->pinned_extents, bytenr,
+                      bytenr + num_bytes - 1, EXTENT_DIRTY, NULL,
+                      GFP_NOFS | __GFP_NOFAIL);
        return 0;
 }
 
@@ -4829,16 +4830,18 @@ btrfs_init_new_buffer(struct btrfs_trans_handle *trans, struct btrfs_root *root,
                 * EXTENT bit to differentiate dirty pages.
                 */
                if (buf->log_index == 0)
-                       set_extent_dirty(&root->dirty_log_pages, buf->start,
-                                       buf->start + buf->len - 1, GFP_NOFS);
+                       set_extent_bit(&root->dirty_log_pages, buf->start,
+                                      buf->start + buf->len - 1,
+                                      EXTENT_DIRTY, NULL, GFP_NOFS);
                else
                        set_extent_bit(&root->dirty_log_pages, buf->start,
                                       buf->start + buf->len - 1,
                                       EXTENT_NEW, NULL, GFP_NOFS);
        } else {
                buf->log_index = -1;
-               set_extent_dirty(&trans->transaction->dirty_pages, buf->start,
-                        buf->start + buf->len - 1, GFP_NOFS);
+               set_extent_bit(&trans->transaction->dirty_pages, buf->start,
+                              buf->start + buf->len - 1, EXTENT_DIRTY, NULL,
+                              GFP_NOFS);
        }
        /* this returns a buffer locked for blocking */
        return buf;