projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e0d2bf5
)
dmaengine: virt-dma: Fix access after free in vchan_complete()
author
Peter Ujfalusi
<peter.ujfalusi@ti.com>
Fri, 20 Dec 2019 13:11:00 +0000
(15:11 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 9 Jan 2020 09:20:00 +0000
(10:20 +0100)
commit
24461d9792c2c706092805ff1b067628933441bd
upstream.
vchan_vdesc_fini() is freeing up 'vd' so the access to vd->tx_result is
via already freed up memory.
Move the vchan_vdesc_fini() after invoking the callback to avoid this.
Fixes:
09d5b702b0f97
("dmaengine: virt-dma: store result on dma descriptor")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Link:
https://lore.kernel.org/r/20191220131100.21804-1-peter.ujfalusi@ti.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/virt-dma.c
patch
|
blob
|
history
diff --git
a/drivers/dma/virt-dma.c
b/drivers/dma/virt-dma.c
index
ec4adf4
..
256fc66
100644
(file)
--- a/
drivers/dma/virt-dma.c
+++ b/
drivers/dma/virt-dma.c
@@
-104,9
+104,8
@@
static void vchan_complete(unsigned long arg)
dmaengine_desc_get_callback(&vd->tx, &cb);
list_del(&vd->node);
- vchan_vdesc_fini(vd);
-
dmaengine_desc_callback_invoke(&cb, &vd->tx_result);
+ vchan_vdesc_fini(vd);
}
}