Fix static analysis issue

Use of auto that causes a copy

Change-Id: Icf30d1e3575c198951ca5d0db2411b3bc0d3cc67
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/src/theme_provider/db_manager.cc b/src/theme_provider/db_manager.cc
index 1ec7a9a..b85f36c 100644 (file)
--- a/src/theme_provider/db_manager.cc
+++ b/src/theme_provider/db_manager.cc
@@ -123,7 +123,7 @@ DbManager::~DbManager() {
 bool DbManager::Insert(const tizen_base::Bundle& info) {
   auto raw = const_cast<tizen_base::Bundle&>(info).ToRaw();
   std::vector<unsigned char> v(raw.first.get(), raw.first.get() + raw.second);
-  auto q = tizen_base::Database::Sql(kInsertQuery)
+  auto q = std::move(tizen_base::Database::Sql(kInsertQuery)
       .SetEmptyStringAsNull(true)
       .Bind(info.GetString("id"))
       .Bind(info.GetString("pkgid"))
@@ -134,7 +134,7 @@ bool DbManager::Insert(const tizen_base::Bundle& info) {
       .Bind(info.GetString("/preview"))
       .Bind(info.GetString("/resolution"))
       .Bind(info.GetString("is_default"))
-      .Bind(std::move(v));
+      .Bind(std::move(v)));
 
   auto r = conn_.Exec(q);
   if (!static_cast<bool>(r)) {
@@ -148,7 +148,7 @@ bool DbManager::Insert(const tizen_base::Bundle& info) {
 bool DbManager::Update(const tizen_base::Bundle& info) {
   auto raw = const_cast<tizen_base::Bundle&>(info).ToRaw();
   std::vector<unsigned char> v(raw.first.get(), raw.first.get() + raw.second);
-  auto q = tizen_base::Database::Sql(kUpdateQuery)
+  auto q = std::move(tizen_base::Database::Sql(kUpdateQuery)
       .SetEmptyStringAsNull(true)
       .Bind(info.GetString("version"))
       .Bind(info.GetString("tool_version"))
@@ -157,7 +157,7 @@ bool DbManager::Update(const tizen_base::Bundle& info) {
       .Bind(info.GetString("preview"))
       .Bind(info.GetString("resolution"))
       .Bind(std::move(v))
-      .Bind(info.GetString("id"));
+      .Bind(info.GetString("id")));
 
   auto r = conn_.Exec(q);
   if (!static_cast<bool>(r)) {
@@ -172,8 +172,8 @@ bool DbManager::Update(const tizen_base::Bundle& info) {
 }
 
 bool DbManager::Delete(const std::string& id) {
-  auto q = tizen_base::Database::Sql(kDeleteQuery)
-      .Bind(id);
+  auto q = std::move(tizen_base::Database::Sql(kDeleteQuery)
+      .Bind(id));
 
   auto r = conn_.Exec(q);
   if (!static_cast<bool>(r)) {
@@ -185,8 +185,8 @@ bool DbManager::Delete(const std::string& id) {
 }
 
 tizen_base::Bundle DbManager::Select(const std::string& id) {
-  auto q = tizen_base::Database::Sql(kSelectQuery)
-      .Bind(id);
+  auto q = std::move(tizen_base::Database::Sql(kSelectQuery)
+      .Bind(id));
 
   auto r = conn_.Exec(q);
   if (!static_cast<bool>(r)) {
@@ -265,8 +265,8 @@ std::vector<std::string> DbManager::SelectIds() {
 }
 
 bool DbManager::UpdateCurrentId(const std::string& id) {
-  auto q = tizen_base::Database::Sql(kSetThemeQuery)
-      .Bind(id);
+  auto q = std::move(tizen_base::Database::Sql(kSetThemeQuery)
+      .Bind(id));
 
   auto r = conn_.Exec(q);
   if (!static_cast<bool>(r)) {