gdb_byte for binary buffer, char for string: common/agent.c.

Similarly to the remote code, agent commands are mostly ascii.  Cast to
gdb_byte when treating the command buffer as raw memory bytes.

2013-04-19  Pedro Alves  <palves@redhat.com>

	* common/agent.c (agent_run_command): Add cast to gdb_byte *.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8b3bfbd..7fd9460 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
+       * common/agent.c (agent_run_command): Add cast to gdb_byte *.
+
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
        * remote.c (remote_write_bytes_aux, compare_sections_command)
        (remote_read_qxfer)
        (remote_search_memory, remote_hostio_pwrite, remote_hostio_pread)

diff --git a/gdb/common/agent.c b/gdb/common/agent.c
index 632310d..f7bedc2 100644 (file)
--- a/gdb/common/agent.c
+++ b/gdb/common/agent.c
@@ -218,7 +218,8 @@ agent_run_command (int pid, const char *cmd, int len)
   int ret = write_inferior_memory (ipa_sym_addrs.addr_cmd_buf,
                                   (const unsigned char *) cmd, len);
 #else
-  int ret = target_write_memory (ipa_sym_addrs.addr_cmd_buf, cmd, len);
+  int ret = target_write_memory (ipa_sym_addrs.addr_cmd_buf,
+                                (gdb_byte *) cmd, len);
 #endif
 
   if (ret != 0)