radv: dump UMR waves before UMR rings
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 22 Jun 2022 08:34:34 +0000 (10:34 +0200)
committerMarge Bot <emma+marge@anholt.net>
Mon, 27 Jun 2022 08:36:49 +0000 (08:36 +0000)
Dumping UMR rings might be slow and dumping waves before would make it
more chance to dump them without reporting "No active waves".

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17183>

src/amd/vulkan/radv_debug.c

index 138dad6..67b4637 100644 (file)
@@ -739,19 +739,19 @@ radv_check_gpu_hangs(struct radv_queue *queue, struct radeon_cmdbuf *cs)
    }
 
    if (!(device->instance->debug_flags & RADV_DEBUG_NO_UMR)) {
-      /* Dump UMR ring. */
-      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_ring.log");
+      /* Dump UMR waves. */
+      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_waves.log");
       f = fopen(dump_path, "w+");
       if (f) {
-         radv_dump_umr_ring(queue, f);
+         radv_dump_umr_waves(queue, f);
          fclose(f);
       }
 
-      /* Dump UMR waves. */
-      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_waves.log");
+      /* Dump UMR ring. */
+      snprintf(dump_path, sizeof(dump_path), "%s/%s", dump_dir, "umr_ring.log");
       f = fopen(dump_path, "w+");
       if (f) {
-         radv_dump_umr_waves(queue, f);
+         radv_dump_umr_ring(queue, f);
          fclose(f);
       }
    }