rtphdrext: Make write function return a signed value

Since the return value is documented to possibly be smaller than 0,
then it needs to be signed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1258>

diff --git a/gst-libs/gst/rtp/gstrtpbasepayload.c b/gst-libs/gst/rtp/gstrtpbasepayload.c
index d092fc7..e72469c 100644 (file)
--- a/gst-libs/gst/rtp/gstrtpbasepayload.c
+++ b/gst-libs/gst/rtp/gstrtpbasepayload.c
@@ -1641,7 +1641,7 @@ write_header_extension (GstRTPHeaderExtension * ext, gpointer user_data)
   gsize remaining =
       hdr->allocated_size - hdr->written_size - hdr->hdr_unit_size;
   gsize offset = hdr->written_size + hdr->hdr_unit_size;
-  gsize written;
+  gssize written;
   guint ext_id;
 
   if (hdr->abort)

diff --git a/gst-libs/gst/rtp/gstrtphdrext.c b/gst-libs/gst/rtp/gstrtphdrext.c
index 6e5921a..44649df 100644 (file)
--- a/gst-libs/gst/rtp/gstrtphdrext.c
+++ b/gst-libs/gst/rtp/gstrtphdrext.c
@@ -279,7 +279,7 @@ gst_rtp_header_extension_get_max_size (GstRTPHeaderExtension * ext,
  *
  * Since: 1.20
  */
-gsize
+gssize
 gst_rtp_header_extension_write (GstRTPHeaderExtension * ext,
     const GstBuffer * input_meta, GstRTPHeaderExtensionFlags write_flags,
     GstBuffer * output, guint8 * data, gsize size)

diff --git a/gst-libs/gst/rtp/gstrtphdrext.h b/gst-libs/gst/rtp/gstrtphdrext.h
index fe9a549..d68a25d 100644 (file)
--- a/gst-libs/gst/rtp/gstrtphdrext.h
+++ b/gst-libs/gst/rtp/gstrtphdrext.h
@@ -159,7 +159,7 @@ struct _GstRTPHeaderExtensionClass
   gsize                 (*get_max_size)             (GstRTPHeaderExtension * ext,
                                                      const GstBuffer * input_meta);
 
-  gsize                 (*write)                    (GstRTPHeaderExtension * ext,
+  gssize                (*write)                    (GstRTPHeaderExtension * ext,
                                                      const GstBuffer * input_meta,
                                                      GstRTPHeaderExtensionFlags write_flags,
                                                      GstBuffer * output,
@@ -210,7 +210,7 @@ GST_RTP_API
 void                gst_rtp_header_extension_set_id             (GstRTPHeaderExtension * ext,
                                                                  guint ext_id);
 GST_RTP_API
-gsize               gst_rtp_header_extension_write              (GstRTPHeaderExtension * ext,
+gssize              gst_rtp_header_extension_write              (GstRTPHeaderExtension * ext,
                                                                  const GstBuffer * input_meta,
                                                                  GstRTPHeaderExtensionFlags write_flags,
                                                                  GstBuffer * output,

diff --git a/tests/check/libs/rtpdummyhdrextimpl.c b/tests/check/libs/rtpdummyhdrextimpl.c
index e5d09af..3144a7c 100644 (file)
--- a/tests/check/libs/rtpdummyhdrextimpl.c
+++ b/tests/check/libs/rtpdummyhdrextimpl.c
@@ -74,7 +74,7 @@ static GstRTPHeaderExtensionFlags
 gst_rtp_dummy_hdr_ext_get_supported_flags (GstRTPHeaderExtension * ext);
 static gsize gst_rtp_dummy_hdr_ext_get_max_size (GstRTPHeaderExtension * ext,
     const GstBuffer * input_meta);
-static gsize gst_rtp_dummy_hdr_ext_write (GstRTPHeaderExtension * ext,
+static gssize gst_rtp_dummy_hdr_ext_write (GstRTPHeaderExtension * ext,
     const GstBuffer * input_meta, GstRTPHeaderExtensionFlags write_flags,
     GstBuffer * output, guint8 * data, gsize size);
 static gboolean gst_rtp_dummy_hdr_ext_read (GstRTPHeaderExtension * ext,
@@ -168,7 +168,7 @@ gst_rtp_dummy_hdr_ext_get_max_size (GstRTPHeaderExtension * ext,
 
 #define TEST_DATA_BYTE 0x9d
 
-static gsize
+static gssize
 gst_rtp_dummy_hdr_ext_write (GstRTPHeaderExtension * ext,
     const GstBuffer * input_meta, GstRTPHeaderExtensionFlags write_flags,
     GstBuffer * output, guint8 * data, gsize size)

diff --git a/tests/check/libs/rtphdrext.c b/tests/check/libs/rtphdrext.c
index 5b2e671..12464d2 100644 (file)
--- a/tests/check/libs/rtphdrext.c
+++ b/tests/check/libs/rtphdrext.c
@@ -35,7 +35,8 @@ GST_START_TEST (rtp_header_ext_write)
   GstRTPHeaderExtension *dummy;
   GstBuffer *buffer;
   guint8 *data;
-  gsize size, written;
+  gsize size;
+  gssize written;
 
   dummy = rtp_dummy_hdr_ext_new ();
   gst_rtp_header_extension_set_id (dummy, 1);