usb: usbip tool: Fix refresh_imported_device_list()
authorYuyang Du <yuyang.du@intel.com>
Mon, 22 May 2017 10:20:17 +0000 (18:20 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Jun 2017 08:48:24 +0000 (10:48 +0200)
The commit 0775a9cbc694e8c7 ("usbip: vhci extension: modifications
to vhci driver") introduced multiple controllers, but the status
of the ports are only extracted from the first status file, fix it.

Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Yuyang Du <yuyang.du@intel.com>
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/usb/usbip/libsrc/vhci_driver.c

index f6f3a19..aa82c4b 100644 (file)
@@ -108,18 +108,33 @@ static int parse_status(const char *value)
        return 0;
 }
 
+#define MAX_STATUS_NAME 16
+
 static int refresh_imported_device_list(void)
 {
        const char *attr_status;
+       char status[MAX_STATUS_NAME+1] = "status";
+       int i, ret;
 
-       attr_status = udev_device_get_sysattr_value(vhci_driver->hc_device,
-                                              "status");
-       if (!attr_status) {
-               err("udev_device_get_sysattr_value failed");
-               return -1;
+       for (i = 0; i < vhci_driver->ncontrollers; i++) {
+               if (i > 0)
+                       snprintf(status, sizeof(status), "status.%d", i);
+
+               attr_status = udev_device_get_sysattr_value(vhci_driver->hc_device,
+                                                           status);
+               if (!attr_status) {
+                       err("udev_device_get_sysattr_value failed");
+                       return -1;
+               }
+
+               dbg("controller %d", i);
+
+               ret = parse_status(attr_status);
+               if (ret != 0)
+                       return ret;
        }
 
-       return parse_status(attr_status);
+       return 0;
 }
 
 static int get_nports(void)