arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper
authorDouglas Anderson <dianders@chromium.org>
Thu, 12 Dec 2019 19:35:42 +0000 (11:35 -0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 12 Dec 2019 23:18:41 +0000 (15:18 -0800)
The bindings for the QMP PHY are truly strange.  I believe (?) that
they may have originated because with PCIe each lane is treated as a
different PHY and the same PHY driver is used for a whole bunch of
things (incluidng PCIe).

In any case, now that we have "make dtbs_check", we find that having
the outer node named "phy" triggers the
"schemas/phy/phy-provider.yaml" schema, yelling about:

  phy@88e9000: '#phy-cells' is a required property

Let's call the outer node the "phy-wrapper" and the inner node the
"phy" to make dtbs_check happy.

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20191212113540.6.Iec10b23bb000186b36b8bacfb6789d8233de04a7@changeid
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/sc7180.dtsi

index d114fea..52a5861 100644 (file)
                        nvmem-cells = <&qusb2p_hstx_trim>;
                };
 
-               usb_1_qmpphy: phy@88e9000 {
+               usb_1_qmpphy: phy-wrapper@88e9000 {
                        compatible = "qcom,sc7180-qmp-usb3-phy";
                        reg = <0 0x088e9000 0 0x18c>,
                              <0 0x088e8000 0 0x38>;
                                 <&gcc GCC_USB3_PHY_PRIM_BCR>;
                        reset-names = "phy", "common";
 
-                       usb_1_ssphy: lanes@88e9200 {
+                       usb_1_ssphy: phy@88e9200 {
                                reg = <0 0x088e9200 0 0x128>,
                                      <0 0x088e9400 0 0x200>,
                                      <0 0x088e9c00 0 0x218>,