drm/amd/display: adjust bit comparison to be more type safe
authorEric Yang <Eric.Yang2@amd.com>
Fri, 10 Dec 2021 17:28:57 +0000 (12:28 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 18 Jan 2022 22:41:18 +0000 (17:41 -0500)
Might potentially have truncation problem with the implicit casting

Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Eric Yang <Eric.Yang2@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c

index fa05691..82c6515 100644 (file)
@@ -441,7 +441,7 @@ void dmub_dcn31_get_diagnostic_data(struct dmub_srv *dmub, struct dmub_diagnosti
 bool dmub_dcn31_should_detect(struct dmub_srv *dmub)
 {
        uint32_t fw_boot_status = REG_READ(DMCUB_SCRATCH0);
-       bool should_detect = fw_boot_status & DMUB_FW_BOOT_STATUS_BIT_DETECTION_REQUIRED;
+       bool should_detect = (fw_boot_status & DMUB_FW_BOOT_STATUS_BIT_DETECTION_REQUIRED) != 0;
        return should_detect;
 }