[coco] Support Bag destruction (#1463)

This commit extends BagManager with destroy method. This change allows
users to safely destruct bags allocated via Bagmanager.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>

diff --git a/contrib/coco/core/include/coco/IR/BagManager.h b/contrib/coco/core/include/coco/IR/BagManager.h
index 42cf793..81851bd 100644 (file)
--- a/contrib/coco/core/include/coco/IR/BagManager.h
+++ b/contrib/coco/core/include/coco/IR/BagManager.h
@@ -20,6 +20,12 @@ public:
 public:
   Bag *create(uint32_t size);
 
+public:
+  // @brief Destroy (= deallocate) a Bag entity
+  //
+  // NOTE A Bag SHOULD BE detached from IR before destruction
+  void destroy(Bag *b);
+
 private:
   PtrLink<Bag, BagInfo> *const _link;
 };

diff --git a/contrib/coco/core/src/IR/BagManager.cpp b/contrib/coco/core/src/IR/BagManager.cpp
index 36ff82f..fce9344 100644 (file)
--- a/contrib/coco/core/src/IR/BagManager.cpp
+++ b/contrib/coco/core/src/IR/BagManager.cpp
@@ -19,4 +19,6 @@ Bag *BagManager::create(uint32_t size)
   return take(std::move(bag));
 }
 
+void BagManager::destroy(Bag *b) { release(b); }
+
 } // namespace coco

diff --git a/contrib/coco/core/src/IR/BagManager.test.cpp b/contrib/coco/core/src/IR/BagManager.test.cpp
index a165269..43fa616 100644 (file)
--- a/contrib/coco/core/src/IR/BagManager.test.cpp
+++ b/contrib/coco/core/src/IR/BagManager.test.cpp
@@ -19,3 +19,14 @@ TEST(IR_BAG_MANAGER, create)
 
   ASSERT_EQ(info->size(), 3);
 }
+
+TEST(IR_BAG_MANAGER, destruct)
+{
+  coco::PtrLink<coco::Bag, coco::BagInfo> bag_link;
+  coco::BagManager mgr{&bag_link};
+
+  auto b = mgr.create(3);
+  mgr.destroy(b);
+
+  ASSERT_EQ(mgr.size(), 0);
+}