scsi: ufs: Avoid to call REQ_CLKS_OFF to CLKS_OFF
authorJaegeuk Kim <jaegeuk@kernel.org>
Tue, 17 Nov 2020 16:58:33 +0000 (08:58 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 Nov 2020 03:00:51 +0000 (22:00 -0500)
Once UFS is gated with CLKS_OFF, it should not call REQ_CLKS_OFF
again. This can lead to hibern8_enter failure.

Link: https://lore.kernel.org/r/20201117165839.1643377-2-jaegeuk@kernel.org
Reviewed-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index 80cbce4..9f53f63 100644 (file)
@@ -1755,7 +1755,8 @@ static void __ufshcd_release(struct ufs_hba *hba)
        if (hba->clk_gating.active_reqs || hba->clk_gating.is_suspended ||
            hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL ||
            ufshcd_any_tag_in_use(hba) || hba->outstanding_tasks ||
-           hba->active_uic_cmd || hba->uic_async_done)
+           hba->active_uic_cmd || hba->uic_async_done ||
+           hba->clk_gating.state == CLKS_OFF)
                return;
 
        hba->clk_gating.state = REQ_CLKS_OFF;