staging: gasket: gasket_mmap use PAGE_MASK
authorTodd Poynor <toddpoynor@google.com>
Fri, 20 Jul 2018 03:49:13 +0000 (20:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Jul 2018 06:50:35 +0000 (08:50 +0200)
gasket_mmap use PAGE_MASK, instead of performing math on PAGE_SIZE, for
simplicity and clarity.

Reported-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Simon Que <sque@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_core.c

index 3cf918f..ae5febe 100644 (file)
@@ -1591,7 +1591,7 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
        }
        driver_desc = gasket_dev->internal_desc->driver_desc;
 
-       if (vma->vm_start & (PAGE_SIZE - 1)) {
+       if (vma->vm_start & ~PAGE_MASK) {
                gasket_log_error(
                        gasket_dev, "Base address not page-aligned: 0x%p\n",
                        (void *)vma->vm_start);