soc: sunxi: sram: Actually claim SRAM regions
authorSamuel Holland <samuel@sholland.org>
Mon, 15 Aug 2022 04:12:40 +0000 (23:12 -0500)
committerJernej Skrabec <jernej.skrabec@gmail.com>
Thu, 8 Sep 2022 20:25:38 +0000 (22:25 +0200)
sunxi_sram_claim() checks the sram_desc->claimed flag before updating
the register, with the intent that only one device can claim a region.
However, this was ineffective because the flag was never set.

Fixes: 4af34b572a85 ("drivers: soc: sunxi: Introduce SoC driver to map SRAMs")
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20220815041248.53268-4-samuel@sholland.org
drivers/soc/sunxi/sunxi_sram.c

index a8f3876..f3d3f92 100644 (file)
@@ -254,6 +254,7 @@ int sunxi_sram_claim(struct device *dev)
        writel(val | ((device << sram_data->offset) & mask),
               base + sram_data->reg);
 
+       sram_desc->claimed = true;
        spin_unlock(&sram_lock);
 
        return 0;