MIPS: SGI-IP30: Free some unused memory
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 23 Apr 2022 13:27:58 +0000 (15:27 +0200)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Tue, 26 Apr 2022 13:07:23 +0000 (15:07 +0200)
platform_device_add_data() duplicates the memory it is passed. So we can
free some memory to save a few bytes that would remain unused otherwise.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/sgi-ip30/ip30-xtalk.c

index 8a28946..8129524 100644 (file)
@@ -63,6 +63,8 @@ static void bridge_platform_create(int widget, int masterwid)
        }
        platform_device_add_resources(pdev, &w1_res, 1);
        platform_device_add_data(pdev, wd, sizeof(*wd));
+       /* platform_device_add_data() duplicates the data */
+       kfree(wd);
        platform_device_add(pdev);
 
        bd = kzalloc(sizeof(*bd), GFP_KERNEL);
@@ -92,6 +94,8 @@ static void bridge_platform_create(int widget, int masterwid)
        bd->io_offset   = IP30_SWIN_BASE(widget);
 
        platform_device_add_data(pdev, bd, sizeof(*bd));
+       /* platform_device_add_data() duplicates the data */
+       kfree(bd);
        platform_device_add(pdev);
        pr_info("xtalk:%x bridge widget\n", widget);
        return;