ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET
authorJohannes Berg <johannes.berg@intel.com>
Wed, 7 Oct 2020 10:53:51 +0000 (12:53 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Oct 2020 23:06:01 +0000 (16:06 -0700)
This accidentally got wired up to the *get* policy instead
of the *set* policy, causing operations to be rejected. Fix
it by wiring up the correct policy instead.

Fixes: 5028588b62cb ("ethtool: wire up set policies to ops")
Reported-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/netlink.c

index 8a85a4e..50d3c88 100644 (file)
@@ -830,8 +830,8 @@ static const struct genl_ops ethtool_genl_ops[] = {
                .cmd    = ETHTOOL_MSG_CHANNELS_SET,
                .flags  = GENL_UNS_ADMIN_PERM,
                .doit   = ethnl_set_channels,
-               .policy = ethnl_channels_get_policy,
-               .maxattr = ARRAY_SIZE(ethnl_channels_get_policy) - 1,
+               .policy = ethnl_channels_set_policy,
+               .maxattr = ARRAY_SIZE(ethnl_channels_set_policy) - 1,
        },
        {
                .cmd    = ETHTOOL_MSG_COALESCE_GET,