block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cach...

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Jim Paris <jim@jtan.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c
index e0e81ca..ba97d03 100644 (file)
--- a/drivers/block/ps3vram.c
+++ b/drivers/block/ps3vram.c
@@ -409,10 +409,8 @@ static int ps3vram_cache_init(struct ps3_system_bus_device *dev)
        priv->cache.page_size = CACHE_PAGE_SIZE;
        priv->cache.tags = kzalloc(sizeof(struct ps3vram_tag) *
                                   CACHE_PAGE_COUNT, GFP_KERNEL);
-       if (priv->cache.tags == NULL) {
-               dev_err(&dev->core, "Could not allocate cache tags\n");
+       if (!priv->cache.tags)
                return -ENOMEM;
-       }
 
        dev_info(&dev->core, "Created ram cache: %d entries, %d KiB each\n",
                CACHE_PAGE_COUNT, CACHE_PAGE_SIZE / 1024);