drivers/base/node.c: make CACHE_ATTR define static DEVICE_ATTR_RO
authorRuiqi Gong <gongruiqi1@huawei.com>
Fri, 14 May 2021 02:05:48 +0000 (10:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 May 2021 20:04:58 +0000 (22:04 +0200)
Mark DEVICE_ATTR_RO(name) in CACHE_ATTR(name, fmt)'s definition as static to fix
the following Sparse tool reports:

drivers/base/node.c:239:1: warning:
 symbol 'dev_attr_line_size' was not declared. Should it be static?
drivers/base/node.c:240:1: warning:
 symbol 'dev_attr_indexing' was not declared. Should it be static?

Where dev_attr_{line_size,indexing} are generated by CACHE_ATTR's expansion.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
Link: https://lore.kernel.org/r/20210514020548.32483-1-gongruiqi1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/node.c

index 2c36f61..6d02103 100644 (file)
@@ -233,7 +233,7 @@ static ssize_t name##_show(struct device *dev,                              \
        return sysfs_emit(buf, fmt "\n",                                \
                          to_cache_info(dev)->cache_attrs.name);        \
 }                                                                      \
-DEVICE_ATTR_RO(name);
+static DEVICE_ATTR_RO(name);
 
 CACHE_ATTR(size, "%llu")
 CACHE_ATTR(line_size, "%u")