drm/vc4: hdmi: Change CSC callback prototype
authorMaxime Ripard <maxime@cerno.tech>
Mon, 18 Jan 2021 08:51:12 +0000 (09:51 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 21 Mar 2022 16:04:35 +0000 (16:04 +0000)
In order to support the YUV output, we'll need the atomic state to know
what is the state of the associated property in the CSC setup callback.

Let's change the prototype of that callback to allow us to access it.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/vc4/vc4_hdmi.c
drivers/gpu/drm/vc4/vc4_hdmi.h

index 7186aa8..955a52d 100644 (file)
@@ -741,6 +741,7 @@ static void vc4_hdmi_encoder_post_crtc_powerdown(struct drm_encoder *encoder,
 }
 
 static void vc4_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
+                              struct drm_connector_state *state,
                               const struct drm_display_mode *mode)
 {
        unsigned long flags;
@@ -828,6 +829,7 @@ static void vc5_hdmi_set_csc_coeffs(struct vc4_hdmi *vc4_hdmi,
 }
 
 static void vc5_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
+                              struct drm_connector_state *state,
                               const struct drm_display_mode *mode)
 {
        unsigned long flags;
@@ -1140,13 +1142,16 @@ static void vc4_hdmi_encoder_pre_crtc_enable(struct drm_encoder *encoder,
                                             struct drm_atomic_state *state)
 {
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
+       struct drm_connector *connector = &vc4_hdmi->connector;
        struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
+       struct drm_connector_state *conn_state =
+               drm_atomic_get_new_connector_state(state, connector);
        unsigned long flags;
 
        mutex_lock(&vc4_hdmi->mutex);
 
        if (vc4_hdmi->variant->csc_setup)
-               vc4_hdmi->variant->csc_setup(vc4_hdmi, mode);
+               vc4_hdmi->variant->csc_setup(vc4_hdmi, conn_state, mode);
 
        spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
        HDMI_WRITE(HDMI_FIFO_CTL, VC4_HDMI_FIFO_CTL_MASTER_SLAVE_N);
index 7468754..e297dfd 100644 (file)
@@ -77,6 +77,7 @@ struct vc4_hdmi_variant {
 
        /* Callback to enable / disable the CSC */
        void (*csc_setup)(struct vc4_hdmi *vc4_hdmi,
+                         struct drm_connector_state *state,
                          const struct drm_display_mode *mode);
 
        /* Callback to configure the video timings in the HDMI block */