avoid truncate string warning when copying 06/258406/1
authorMaciej Słodczyk <m.slodczyk2@partner.samsung.com>
Wed, 27 May 2020 11:00:25 +0000 (13:00 +0200)
committeryoungjae cho <y0.cho@samsung.com>
Mon, 17 May 2021 02:26:47 +0000 (02:26 +0000)
Deliberately copying substring with strncpy() resulted
in 'output may be truncated' warning. Use memcpy()
to achieve the same without the warning.

Change-Id: I8759159e9dd823e78001d4812c52cf2e8588c4e0
Signed-off-by: Maciej Słodczyk <m.slodczyk2@partner.samsung.com>
(cherry picked from commit efc76d963073c094d7f5ab0f6a86f5a40b6a14da)

src/common/procfs.c

index 12698cb9a411e24f554874744cc8b0c3b902be03..b59ed93dde1c0fde23bb4ebc8c49a69241cb879f 100644 (file)
@@ -460,7 +460,7 @@ API int procfs_get_pid_stat(pid_t pid, struct procfs_pid_stat *pps)
 {
        FILE *fp = NULL;
        char buf[BUF_SIZE];
-       char comm[BUF_SIZE];
+       char comm[BUF_SIZE] = {};
 
        if (pid < 1 || !pps) {
                _E("Invalid parameter");
@@ -484,7 +484,7 @@ API int procfs_get_pid_stat(pid_t pid, struct procfs_pid_stat *pps)
                fclose(fp);
                return -ENOENT;
        }
-       strncpy(pps->comm, comm, COMM_SIZE - 1);
+       memcpy(pps->comm, comm, COMM_SIZE - 1);
        pps->comm[COMM_SIZE - 1] = '\0';
 
        fclose(fp);