events: do not accept NaN in setMaxListeners

diff --git a/lib/events.js b/lib/events.js
index 8c02a55..f43df09 100644 (file)
--- a/lib/events.js
+++ b/lib/events.js
@@ -45,7 +45,7 @@ exports.EventEmitter = EventEmitter;
 // that to be increased. Set to zero for unlimited.
 var defaultMaxListeners = 10;
 EventEmitter.prototype.setMaxListeners = function(n) {
-  if (typeof n !== 'number' || n < 0)
+  if (typeof n !== 'number' || n < 0 || isNaN(n))
     throw TypeError('n must be a positive number');
   this._maxListeners = n;
 };

diff --git a/test/simple/test-event-emitter-max-listeners.js b/test/simple/test-event-emitter-max-listeners.js
index 3dea94b..dfc3e13 100644 (file)
--- a/test/simple/test-event-emitter-max-listeners.js
+++ b/test/simple/test-event-emitter-max-listeners.js
@@ -38,4 +38,16 @@ e.on('maxListeners', function() {
 // Should not corrupt the 'maxListeners' queue.
 e.setMaxListeners(42);
 
+assert.throws(function() {
+  e.setMaxListeners(NaN);
+});
+
+assert.throws(function() {
+  e.setMaxListeners(-1);
+});
+
+assert.throws(function() {
+  e.setMaxListeners("and even this");
+});
+
 e.emit('maxListeners');