efi_driver: fix efi_uc_stop()
authorHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Fri, 7 Oct 2022 21:53:38 +0000 (23:53 +0200)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Mon, 10 Oct 2022 14:34:25 +0000 (16:34 +0200)
We must always call EFI_EXIT() when returning from an EFIAPI function.

Fixes: 05ef48a2484b ("efi_driver: EFI block driver")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
lib/efi_driver/efi_uclass.c

index 2193f84..45610d1 100644 (file)
@@ -225,9 +225,10 @@ static efi_status_t EFIAPI efi_uc_stop(
                        ret = disconnect_child(controller_handle,
                                               child_handle_buffer[i]);
                        if (ret != EFI_SUCCESS)
-                               return ret;
+                               goto out;
                }
-               return EFI_SUCCESS;
+               ret = EFI_SUCCESS;
+                       goto out;
        }
 
        /* Destroy all children */