iio: adc: ad7192: Fix internal/external clock selection
authorFabrizio Lamarque <fl.scratchpad@gmail.com>
Tue, 30 May 2023 07:53:08 +0000 (09:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:46 +0000 (16:21 +0200)
commit f7d9e21dd274b97dc0a8dbc136a2ea8506063a96 upstream.

Fix wrong selection of internal clock when mclk is defined.

Resolve a logical inversion introduced in c9ec2cb328e3.

Fixes: c9ec2cb328e3 ("iio: adc: ad7192: use devm_clk_get_optional() for mclk")
Signed-off-by: Fabrizio Lamarque <fl.scratchpad@gmail.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230530075311.400686-3-fl.scratchpad@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/ad7192.c

index c15fa10a469c9f91e51cfcbe688b3784fb81eb02..8720ac43a4a4afa7a1bc1f6a0f12b38218535357 100644 (file)
@@ -368,7 +368,7 @@ static int ad7192_of_clock_select(struct ad7192_state *st)
        clock_sel = AD7192_CLK_INT;
 
        /* use internal clock */
-       if (st->mclk) {
+       if (!st->mclk) {
                if (of_property_read_bool(np, "adi,int-clock-output-enable"))
                        clock_sel = AD7192_CLK_INT_CO;
        } else {