fpga: zynqmp: reduce zynqmppl_load() code

Reduce the function code by calling xilinx_pm_request() once only.
Use the same variable bsize_req to store either bstream size in bytes
or an address of bstream size according to a type required by the
firmware version. Remove obsolete debug().

Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
Tested-by: Ricardo Salveti <ricardo@foundries.io>
Tested-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Link: https://lore.kernel.org/r/20220722141614.297383-11-oleksandr.suvorov@foundries.io
Signed-off-by: Michal Simek <michal.simek@amd.com>

diff --git a/drivers/fpga/zynqmppl.c b/drivers/fpga/zynqmppl.c
index a062456788204e0f9459a824e1735e5ab7ac2014..2791f931861c70a93cde7d083d8a7c04b25169a1 100644 (file)
--- a/drivers/fpga/zynqmppl.c
+++ b/drivers/fpga/zynqmppl.c
@@ -207,38 +207,33 @@ static int zynqmp_load(xilinx_desc *desc, const void *buf, size_t bsize,
        ulong bin_buf;
        int ret;
        u32 buf_lo, buf_hi;
+       u32 bsize_req = (u32)bsize;
        u32 ret_payload[PAYLOAD_ARG_CNT];
-       bool xilfpga_old = false;
 
        if (zynqmp_firmware_version() <= PMUFW_V1_0) {
                puts("WARN: PMUFW v1.0 or less is detected\n");
                puts("WARN: Not all bitstream formats are supported\n");
                puts("WARN: Please upgrade PMUFW\n");
-               xilfpga_old = true;
                if (zynqmp_validate_bitstream(desc, buf, bsize, bsize, &swap))
                        return FPGA_FAIL;
                bsizeptr = (u32 *)&bsize;
                flush_dcache_range((ulong)bsizeptr,
                                   (ulong)bsizeptr + sizeof(size_t));
+               bsize_req = (u32)(uintptr_t)bsizeptr;
                bstype |= BIT(ZYNQMP_FPGA_BIT_NS);
+       } else {
+               bstype = 0;
        }
 
        bin_buf = zynqmp_align_dma_buffer((u32 *)buf, bsize, swap);
 
-       debug("%s called!\n", __func__);
        flush_dcache_range(bin_buf, bin_buf + bsize);
 
        buf_lo = (u32)bin_buf;
        buf_hi = upper_32_bits(bin_buf);
 
-       if (xilfpga_old)
-               ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo,
-                                       buf_hi, (u32)(uintptr_t)bsizeptr,
-                                       bstype, ret_payload);
-       else
-               ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo,
-                                       buf_hi, (u32)bsize, 0, ret_payload);
-
+       ret = xilinx_pm_request(PM_FPGA_LOAD, buf_lo, buf_hi,
+                               bsize_req, bstype, ret_payload);
        if (ret)
                printf("PL FPGA LOAD failed with err: 0x%08x\n", ret);