slider: removed unnecessary key value check in case of key up event

Summary:
This patch removes unnecessary codes.
There is no need to check key value in case of key up event,
since any other key down event except direction keys will cancel sliding.
Instead, hide popup if the popup is visible at that point.

Test Plan: None

Reviewers: Hermet, raster

Reviewed By: Hermet

Differential Revision: https://phab.enlightenment.org/D760

diff --git a/legacy/elementary/src/lib/elm_slider.c b/legacy/elementary/src/lib/elm_slider.c
index 02a6d7f..3faf69b 100644 (file)
--- a/legacy/elementary/src/lib/elm_slider.c
+++ b/legacy/elementary/src/lib/elm_slider.c
@@ -393,20 +393,9 @@ _elm_slider_elm_widget_event(Eo *obj, Elm_Slider_Data *sd, Evas_Object *src, Eva
      }
    else if (type == EVAS_CALLBACK_KEY_UP)
      {
-         Evas_Event_Key_Up *ev_up =  event_info;
-
-         if ((!ev_up->string) &&
-             ((!strcmp(ev_up->key, "Left")) ||
-              (!strcmp(ev_up->key, "KP_Left")) ||
-              (!strcmp(ev_up->key, "Right")) ||
-              (!strcmp(ev_up->key, "KP_Right")) ||
-              (!strcmp(ev_up->key, "Up")) ||
-              (!strcmp(ev_up->key, "KP_Up")) ||
-              (!strcmp(ev_up->key, "Down")) ||
-              (!strcmp(ev_up->key, "KP_Down"))))
-             _popup_hide(obj, NULL, NULL, NULL);
-
-         return EINA_FALSE;
+        if (evas_object_visible_get(sd->popup))
+          _popup_hide(obj, NULL, NULL, NULL);
+        return EINA_FALSE;
      }
    else if (type == EVAS_CALLBACK_MOUSE_WHEEL)
      {