tests: Fix potential g_object_unref(NULL) calls in libebook tests
authorPhilip Withnall <philip.withnall@collabora.co.uk>
Fri, 29 Nov 2013 08:58:40 +0000 (08:58 +0000)
committerMatthew Barnes <mbarnes@redhat.com>
Tue, 3 Dec 2013 22:53:55 +0000 (17:53 -0500)
Found by scan-build.

https://bugzilla.gnome.org/719533

tests/libebook/test-ebook-get-required-fields.c
tests/libebook/test-ebook-get-supported-fields.c

index c3ca138..4c0bfff 100644 (file)
@@ -33,9 +33,9 @@ get_required_fields_cb (EBookTestClosure *closure)
                        e_iterator_next (iter);
                }
                test_print ("----------------\n");
-       }
 
-       g_object_unref (closure->list);
+               g_object_unref (closure->list);
+       }
 
        g_main_loop_quit ((GMainLoop *) (closure->user_data));
 }
index 5af368c..0c4da96 100644 (file)
@@ -33,9 +33,9 @@ get_supported_fields_cb (EBookTestClosure *closure)
                        e_iterator_next (iter);
                }
                test_print ("----------------\n");
-       }
 
-       g_object_unref (closure->list);
+               g_object_unref (closure->list);
+       }
 
        g_main_loop_quit ((GMainLoop *) (closure->user_data));
 }