radesonsi: Remove unsigned comparison to zero.
authorVinson Lee <vlee@freedesktop.org>
Tue, 15 Sep 2020 04:59:55 +0000 (21:59 -0700)
committerMarge Bot <eric+marge@anholt.net>
Thu, 17 Sep 2020 22:59:57 +0000 (22:59 +0000)
cbuf was changed to unsigned in commit 3fec2f67c3d9 ("radeonsi:
compact MRTs to save PS export memory space").

Fix defect reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison of
an unsigned value is always true. cbuf >= 0U.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6739>

src/gallium/drivers/radeonsi/si_shader_llvm_ps.c

index 1f233e1..37711ee 100644 (file)
@@ -253,7 +253,7 @@ static void si_llvm_init_ps_export_args(struct si_shader_context *ctx, LLVMValue
    unsigned chan;
    bool is_int8, is_int10;
 
-   assert(cbuf >= 0 && cbuf < 8);
+   assert(cbuf < 8);
 
    spi_shader_col_format = (col_formats >> (cbuf * 4)) & 0xf;
    is_int8 = (key->part.ps.epilog.color_is_int8 >> cbuf) & 0x1;