Revert "drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()"
authorSean Paul <seanpaul@chromium.org>
Sat, 2 Oct 2021 15:45:32 +0000 (11:45 -0400)
committerSean Paul <seanpaul@chromium.org>
Mon, 4 Oct 2021 13:34:56 +0000 (09:34 -0400)
This reverts commit fd49ef52e2db015ce69ad02bab0702489d141a41.

This patchset breaks on intel platforms and was previously NACK'd by
Ville.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Fernando Ramos <greenfoo@u92.eu>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211002154542.15800-6-sean@poorly.run
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

index b896870748907950311219fcc3f6efe3ff91f540..768012243b44040c76cb09a504349e37f99a1543 100644 (file)
@@ -18,7 +18,6 @@
 #include <drm/drm_probe_helper.h>
 #include <drm/drm_rect.h>
 #include <drm/drm_vblank.h>
-#include <drm/drm_drv.h>
 
 #include "dpu_kms.h"
 #include "dpu_hw_lm.h"
@@ -1173,15 +1172,14 @@ static int _dpu_debugfs_status_show(struct seq_file *s, void *data)
        struct drm_display_mode *mode;
        struct drm_framebuffer *fb;
        struct drm_plane_state *state;
-       struct drm_modeset_acquire_ctx ctx;
        struct dpu_crtc_state *cstate;
 
-       int i, out_width, ret;
+       int i, out_width;
 
        dpu_crtc = s->private;
        crtc = &dpu_crtc->base;
 
-       DRM_MODESET_LOCK_ALL_BEGIN(crtc->dev, ctx, 0, ret);
+       drm_modeset_lock_all(crtc->dev);
        cstate = to_dpu_crtc_state(crtc->state);
 
        mode = &crtc->state->adjusted_mode;
@@ -1265,9 +1263,9 @@ static int _dpu_debugfs_status_show(struct seq_file *s, void *data)
                dpu_crtc->vblank_cb_time = ktime_set(0, 0);
        }
 
-       DRM_MODESET_LOCK_ALL_END(crtc->dev, ctx, ret);
+       drm_modeset_unlock_all(crtc->dev);
 
-       return ret;
+       return 0;
 }
 
 DEFINE_SHOW_ATTRIBUTE(_dpu_debugfs_status);