Roll variables into an LLVM_DEBUG block to address -Wunused-but-set-variable
authorDavid Blaikie <dblaikie@gmail.com>
Tue, 26 May 2020 19:04:14 +0000 (12:04 -0700)
committerDavid Blaikie <dblaikie@gmail.com>
Tue, 26 May 2020 19:05:08 +0000 (12:05 -0700)
llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp

index cc7a7e2..ee21972 100644 (file)
@@ -83,8 +83,6 @@ private:
 
       for (auto SymRef : *Symbols) {
         Optional<StringRef> Name;
-        unsigned char Binding;
-        uint64_t Value;
         uint64_t Size = 0;
 
         // FIXME: Read size.
@@ -95,17 +93,15 @@ private:
         } else {
           return NameOrErr.takeError();
         }
-        Binding = SymRef.getBinding();
-        Value = SymRef.getValue();
         LLVM_DEBUG({
           dbgs() << "  ";
           if (!Name)
             dbgs() << "<anonymous symbol>";
           else
             dbgs() << *Name;
-          dbgs() << ": value = " << formatv("{0:x16}", Value)
+          dbgs() << ": value = " << formatv("{0:x16}", SymRef.getValue())
                  << ", type = " << formatv("{0:x2}", SymRef.getType())
-                 << ", binding = " << Binding
+                 << ", binding = " << SymRef.getBinding()
                  << ", size =" << Size;
           dbgs() << "\n";
         });