dmaengine: ti: edma: handle irq_of_parse_and_map() errors
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 15 Sep 2023 12:59:59 +0000 (15:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Nov 2023 10:52:10 +0000 (11:52 +0100)
[ Upstream commit 14f6d317913f634920a640e9047aa2e66f5bdcb7 ]

Zero is not a valid IRQ for in-kernel code and the irq_of_parse_and_map()
function returns zero on error.  So this check for valid IRQs should only
accept values > 0.

Fixes: 2b6b3b742019 ("ARM/dmaengine: edma: Merge the two drivers under drivers/dma/")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/f15cb6a7-8449-4f79-98b6-34072f04edbc@moroto.mountain
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/ti/edma.c

index fa06d7e..7ec6e5d 100644 (file)
@@ -2410,7 +2410,7 @@ static int edma_probe(struct platform_device *pdev)
        if (irq < 0 && node)
                irq = irq_of_parse_and_map(node, 0);
 
-       if (irq >= 0) {
+       if (irq > 0) {
                irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint",
                                          dev_name(dev));
                ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name,
@@ -2426,7 +2426,7 @@ static int edma_probe(struct platform_device *pdev)
        if (irq < 0 && node)
                irq = irq_of_parse_and_map(node, 2);
 
-       if (irq >= 0) {
+       if (irq > 0) {
                irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint",
                                          dev_name(dev));
                ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name,