vaapipostproc: params video_info_changed() callers
authorVíctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Thu, 12 Nov 2015 15:13:25 +0000 (16:13 +0100)
committerVíctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Thu, 19 Nov 2015 11:23:22 +0000 (12:23 +0100)
The signature is video_info_changed(old_vip, new_vip). Nonetheless the callers
swapped the the order. This didn't raise problems since the comparison of both
structures were not affected by its semantics.

But still it would be better to fix this to keep the coherence of the code.

Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
https://bugzilla.gnome.org/show_bug.cgi?id=758007

gst/vaapi/gstvaapipostproc.c

index 38fa9b5..18f3474 100644 (file)
@@ -867,7 +867,7 @@ gst_vaapipostproc_update_sink_caps (GstVaapiPostproc * postproc, GstCaps * caps,
   if (!gst_video_info_from_caps (&vi, caps))
     return FALSE;
 
-  if (video_info_changed (&vi, &postproc->sinkpad_info))
+  if (video_info_changed (&postproc->sinkpad_info, &vi))
     postproc->sinkpad_info = vi, *caps_changed_ptr = TRUE;
 
   deinterlace = is_deinterlace_enabled (postproc, &vi);
@@ -892,7 +892,7 @@ gst_vaapipostproc_update_src_caps (GstVaapiPostproc * postproc, GstCaps * caps,
   if (!gst_video_info_from_caps (&vi, caps))
     return FALSE;
 
-  if (video_info_changed (&vi, &postproc->srcpad_info))
+  if (video_info_changed (&postproc->srcpad_info, &vi))
     postproc->srcpad_info = vi, *caps_changed_ptr = TRUE;
 
   if (postproc->format != GST_VIDEO_INFO_FORMAT (&postproc->sinkpad_info) &&
@@ -1217,7 +1217,7 @@ ensure_srcpad_buffer_pool (GstVaapiPostproc * postproc, GstCaps * caps)
       GST_VIDEO_INFO_WIDTH (&vi), GST_VIDEO_INFO_HEIGHT (&vi));
 
   if (postproc->filter_pool
-      && !video_info_changed (&vi, &postproc->filter_pool_info))
+      && !video_info_changed (&postproc->filter_pool_info, &vi))
     return TRUE;
   postproc->filter_pool_info = vi;