xfs: remove redundant pointer lip
authorColin Ian King <colin.i.king@gmail.com>
Tue, 18 Oct 2022 21:37:39 +0000 (14:37 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 20 Oct 2022 16:42:56 +0000 (09:42 -0700)
The assignment to pointer lip is not really required, the pointer lip
is redundant and can be removed.

Cleans up clang-scan warning:
warning: Although the value stored to 'lip' is used in the enclosing
expression, the value is never actually read from 'lip'
[deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/xfs_trans_ail.c

index 16fbf2a..f51df7d 100644 (file)
@@ -730,11 +730,10 @@ void
 xfs_ail_push_all_sync(
        struct xfs_ail  *ailp)
 {
-       struct xfs_log_item     *lip;
        DEFINE_WAIT(wait);
 
        spin_lock(&ailp->ail_lock);
-       while ((lip = xfs_ail_max(ailp)) != NULL) {
+       while (xfs_ail_max(ailp) != NULL) {
                prepare_to_wait(&ailp->ail_empty, &wait, TASK_UNINTERRUPTIBLE);
                wake_up_process(ailp->ail_task);
                spin_unlock(&ailp->ail_lock);