xhci: Use setup_timer
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 9 Jan 2015 14:06:29 +0000 (16:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Jan 2015 18:05:47 +0000 (10:05 -0800)
Convert a call to init_timer and accompanying intializations of
the timer's data and function fields to a call to setup_timer.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression t,f,d;
@@

-init_timer(&t);
+setup_timer(&t,f,d);
-t.data = d;
-t.function = f;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci.c

index 5ec74e2..1e3f39c 100644 (file)
@@ -472,10 +472,8 @@ static void compliance_mode_recovery(unsigned long arg)
 static void compliance_mode_recovery_timer_init(struct xhci_hcd *xhci)
 {
        xhci->port_status_u0 = 0;
-       init_timer(&xhci->comp_mode_recovery_timer);
-
-       xhci->comp_mode_recovery_timer.data = (unsigned long) xhci;
-       xhci->comp_mode_recovery_timer.function = compliance_mode_recovery;
+       setup_timer(&xhci->comp_mode_recovery_timer,
+                   compliance_mode_recovery, (unsigned long)xhci);
        xhci->comp_mode_recovery_timer.expires = jiffies +
                        msecs_to_jiffies(COMP_MODE_RCVRY_MSECS);