staging: rtl8712: r8712_addbareq_cmd(): Change return type
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Fri, 21 Jun 2019 06:08:07 +0000 (11:38 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Jun 2019 14:46:17 +0000 (16:46 +0200)
Change return type of the function r8712_addbareq_cmd from u8 to void as
its return value is not stored, checked or otherwise used. Also modify
its return statements accordingly.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/rtl871x_cmd.c
drivers/staging/rtl8712/rtl871x_cmd.h

index cc55fa5..8d110cc 100644 (file)
@@ -739,7 +739,7 @@ u8 r8712_setassocsta_cmd(struct _adapter *padapter, u8 *mac_addr)
        return _SUCCESS;
 }
 
-u8 r8712_addbareq_cmd(struct _adapter *padapter, u8 tid)
+void r8712_addbareq_cmd(struct _adapter *padapter, u8 tid)
 {
        struct cmd_priv         *pcmdpriv = &padapter->cmdpriv;
        struct cmd_obj          *ph2c;
@@ -747,17 +747,16 @@ u8 r8712_addbareq_cmd(struct _adapter *padapter, u8 tid)
 
        ph2c = kmalloc(sizeof(*ph2c), GFP_ATOMIC);
        if (!ph2c)
-               return _FAIL;
+               return;
        paddbareq_parm = kmalloc(sizeof(*paddbareq_parm), GFP_ATOMIC);
        if (!paddbareq_parm) {
                kfree(ph2c);
-               return _FAIL;
+               return;
        }
        paddbareq_parm->tid = tid;
        init_h2fwcmd_w_parm_no_rsp(ph2c, paddbareq_parm,
                                   GEN_CMD_CODE(_AddBAReq));
        r8712_enqueue_cmd_ex(pcmdpriv, ph2c);
-       return _SUCCESS;
 }
 
 u8 r8712_wdg_wk_cmd(struct _adapter *padapter)
index d9aab41..8448dd0 100644 (file)
@@ -729,7 +729,7 @@ u8 r8712_setrttbl_cmd(struct _adapter  *padapter,
                      struct setratable_parm *prate_table);
 u8 r8712_setfwdig_cmd(struct _adapter *padapter, u8 type);
 u8 r8712_setfwra_cmd(struct _adapter *padapter, u8 type);
-u8 r8712_addbareq_cmd(struct _adapter *padapter, u8 tid);
+void r8712_addbareq_cmd(struct _adapter *padapter, u8 tid);
 u8 r8712_wdg_wk_cmd(struct _adapter *padapter);
 void r8712_survey_cmd_callback(struct _adapter  *padapter,
                               struct cmd_obj *pcmd);