scsi: qedf: Remove redundant variable op
authorColin Ian King <colin.i.king@gmail.com>
Tue, 17 May 2022 09:25:18 +0000 (10:25 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 20 May 2022 00:16:26 +0000 (20:16 -0400)
The variable 'op' is assigned a value and is never read. The variable is
not used and is redundant, remove it.

Link: https://lore.kernel.org/r/20220517092518.93159-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_io.c

index 2ec1f71..e57cc22 100644 (file)
@@ -804,7 +804,6 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,
        struct qedf_io_log *io_log;
        struct scsi_cmnd *sc_cmd = io_req->sc_cmd;
        unsigned long flags;
-       uint8_t op;
 
        spin_lock_irqsave(&qedf->io_trace_lock, flags);
 
@@ -813,7 +812,7 @@ static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,
        io_log->task_id = io_req->xid;
        io_log->port_id = fcport->rdata->ids.port_id;
        io_log->lun = sc_cmd->device->lun;
-       io_log->op = op = sc_cmd->cmnd[0];
+       io_log->op = sc_cmd->cmnd[0];
        io_log->lba[0] = sc_cmd->cmnd[2];
        io_log->lba[1] = sc_cmd->cmnd[3];
        io_log->lba[2] = sc_cmd->cmnd[4];