Remove pooled objects from alloc_callback_fail group
authorMaciej Jesionowski <maciej.jesionowski@mobica.com>
Mon, 9 Jan 2017 11:05:32 +0000 (12:05 +0100)
committerPyry Haulos <phaulos@google.com>
Mon, 9 Jan 2017 17:14:02 +0000 (12:14 -0500)
The pooled objects (VkDescriptorSet and VkCommandBuffer) are properly
handled in the alloc_callback_fail_multiple group. The removed cases
were redundant, and also didn't work correctly with pooled objects.

Removed tests:
- dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
- dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
- dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary

Change-Id: I212b544096e6e1fd5b98c7985d836e41247107e9

android/cts/master/vk-master.txt
android/cts/nyc/src/vk-master.txt
android/cts/nyc/vk-master.txt
external/vulkancts/modules/vulkan/api/vktApiObjectManagementTests.cpp
external/vulkancts/mustpass/1.0.0/src/master.txt
external/vulkancts/mustpass/1.0.0/vk-default.txt
external/vulkancts/mustpass/1.0.1/src/master.txt
external/vulkancts/mustpass/1.0.1/vk-default.txt
external/vulkancts/mustpass/1.0.2/vk-default.txt

index 5d9df35fad6de13c986beaf59316bc336e8f031d..e020cf9a119365e968fffbd7fa80e90e3a479414 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.graphics_pipeline
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.compute_pipeline
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.descriptor_set
index 48b84cc0eb8006e2e0516ddd8dbb21d53195a08e..2553a8a3cba82416f05a3394fda17b851e716405 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index 14f206a0ccd48b2cbc99bc05e16402e27e24ad6a..61f575e878b57ce9e54b82066cfaa5577499c9dc 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index e1b824aaad0804100633bf97714d7ff0c71c23d5..cd556d3c1a2ce62aad6264623aadf06d0223a684 100644 (file)
@@ -3068,6 +3068,7 @@ tcu::TestCaseGroup* createObjectManagementTests (tcu::TestContext& testCtx)
        };
        objectMgmtTests->addChild(createGroup(testCtx, "single_alloc_callbacks", "Create single object", s_createSingleAllocCallbacksGroup));
 
+       // \note Skip pooled objects in this test group. They are properly handled by the "multiple" group farther down below.
        static const CaseDescriptions   s_allocCallbackFailGroup        =
        {
                CASE_DESC(allocCallbackFailTest <Instance>,                                     s_instanceCases),
@@ -3090,10 +3091,10 @@ tcu::TestCaseGroup* createObjectManagementTests (tcu::TestContext& testCtx)
                CASE_DESC(allocCallbackFailTest <DescriptorSetLayout>,          s_descriptorSetLayoutCases),
                CASE_DESC(allocCallbackFailTest <Sampler>,                                      s_samplerCases),
                CASE_DESC(allocCallbackFailTest <DescriptorPool>,                       s_descriptorPoolCases),
-               CASE_DESC(allocCallbackFailTest <DescriptorSet>,                        s_descriptorSetCases),
+               EMPTY_CASE_DESC(DescriptorSet),
                CASE_DESC(allocCallbackFailTest <Framebuffer>,                          s_framebufferCases),
                CASE_DESC(allocCallbackFailTest <CommandPool>,                          s_commandPoolCases),
-               CASE_DESC(allocCallbackFailTest <CommandBuffer>,                        s_commandBufferCases),
+               EMPTY_CASE_DESC(CommandBuffer),
        };
        objectMgmtTests->addChild(createGroup(testCtx, "alloc_callback_fail", "Allocation callback failure", s_allocCallbackFailGroup));
 
index 9396cb95604d3763c38c62f3c66a513fd9ef6fd8..474176fa76b69099993959fdb9aaa270a3882b61 100644 (file)
@@ -1676,12 +1676,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index b3624d60c99077b84a3cfd3b3f9735ce7068d45c..87d7ad4634c63856736b2c337ea65646f3a045a1 100644 (file)
@@ -1676,12 +1676,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index 2f35ecb1da2e945ab86cb3e96f4d939fc44c43f5..dc5c7e71c0ab1aa9f79e098c85c2f189b46b2166 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index 2f35ecb1da2e945ab86cb3e96f4d939fc44c43f5..dc5c7e71c0ab1aa9f79e098c85c2f189b46b2166 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.buffer.create_buffer_1_0
 dEQP-VK.api.buffer.create_buffer_2_0
 dEQP-VK.api.buffer.create_buffer_3_0
index 58b7a57ecfe43ed6490cb304542087a5532ec704..26ecbbeb54e77324b4d6fb5d18d67f176ea3820f 100644 (file)
@@ -1680,12 +1680,9 @@ dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_empty
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set_layout_single
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool
 dEQP-VK.api.object_management.alloc_callback_fail.descriptor_pool_free_descriptor_set
-dEQP-VK.api.object_management.alloc_callback_fail.descriptor_set
 dEQP-VK.api.object_management.alloc_callback_fail.framebuffer
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool
 dEQP-VK.api.object_management.alloc_callback_fail.command_pool_transient
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_primary
-dEQP-VK.api.object_management.alloc_callback_fail.command_buffer_secondary
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.graphics_pipeline
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.compute_pipeline
 dEQP-VK.api.object_management.alloc_callback_fail_multiple.descriptor_set